Hesh 2.7.2 + Mods for Hesk: still little bugs...
Posted: Fri Jan 27, 2017 10:16 am
Dear Mike,
last fall I wrote you about some little bugs I found in the combination of Hesk 2.6.8+MfH 2.6.4.
Now that "stable releases" 2.7.2+3.0.3 were released I found the same bugs unsolved, plus what maybe is another possible bug.
Thety are not relevant, but I report here because maybe someone can find useful the workaround I set.
1. "New bug"
In the language "text.php" there are these two variables:
$hesklang['select_all_title_case']
$hesklang['deselect_all_title_case']
I saw they are used at least in the sidebar of the administration where I found their behaviour is exacly opposite of what they are set to, ie when you click on the button whose associate variable is $hesklang['select_all_title_case'] an 'unselect' action happens and viceversa.
I don't know if they are used in some other placea, but at least in the sidebar I found this, so in the Italian translation (BTW do you need it?) I switched them.
2. I reported that "Edit Category" is a string and not a variable inside the file administration/manage_categories.php
So in order to allow a localization into Italian (and this could be useful for users of non-English languages) I changed these two lines:
a. manage_categories.php (about line 353)
/* L. Saggin Modification */
echo '<a href="javascript:;" class="category-modal-trigger" data-category-id="' . $mycat['id'] . '"><i class="fa fa-pencil icon-link orange" data-toggle="tooltip" title="Modifica"></i></a>';
/* L. Saggin End of modification */
b. manage_categories.php about line 373
<!-- L. Saggin Modification -->
<h4 class="modal-title" id="myModalLabel">Modifica Categoria</h4>
<!-- L. Saggin End Modification -->
This way, however I cannot provide an English language fully supported anymore. Better: if one translates these two lines then (s)he has to choose which language should be fully supported.
I know, I'm finicky
3. This is more a problem for me, but can be general for all those who requires a full implementation of the Name of the customers.
In fact the ticket form reports the field "Name" and the customer must indicate his/her Name. That is correct.
However my experience is that persons use *JUST* their Name, not their surname+name!
We are a Interdepartmental University facility and our helpdesk is only for an internal users. So we need to identify *exactly* who is submitting ticket (the email cannot be always useful). In our case there is no problem of privacy: if someone wants to have his/her not working air conditioning system or his/her dropping taps fixed in his/her labs, then we must know who is who.
So at first I tried to translate $hesklang['name'] as "Cognome e Nome" (ie Surname & Name) and NOT "Name".
Unfortunately this variable is used also in other places where it must be exactly "Name" and NOT "Surname & Name".
So I decided to leave it as it was, and I added another variable, I called $hesklang['surname'] which I substituted in the file "index.php" of the root directory as reported below:
index.php line 318
/* L. Saggin Modification */
} ?> placeholder="<?php echo htmlspecialchars($hesklang['surname']); ?>"
/* L. Saggin End of Modification*/
This way when one submits a ticket, then at least (s)he sees inside the box whose label (fieldname) is "Name" that (s)he has to fill in with *both* Name and Surname.
Thanks for the attention.
Topoldo/Leopoldo
last fall I wrote you about some little bugs I found in the combination of Hesk 2.6.8+MfH 2.6.4.
Now that "stable releases" 2.7.2+3.0.3 were released I found the same bugs unsolved, plus what maybe is another possible bug.
Thety are not relevant, but I report here because maybe someone can find useful the workaround I set.
1. "New bug"
In the language "text.php" there are these two variables:
$hesklang['select_all_title_case']
$hesklang['deselect_all_title_case']
I saw they are used at least in the sidebar of the administration where I found their behaviour is exacly opposite of what they are set to, ie when you click on the button whose associate variable is $hesklang['select_all_title_case'] an 'unselect' action happens and viceversa.
I don't know if they are used in some other placea, but at least in the sidebar I found this, so in the Italian translation (BTW do you need it?) I switched them.
2. I reported that "Edit Category" is a string and not a variable inside the file administration/manage_categories.php
So in order to allow a localization into Italian (and this could be useful for users of non-English languages) I changed these two lines:
a. manage_categories.php (about line 353)
/* L. Saggin Modification */
echo '<a href="javascript:;" class="category-modal-trigger" data-category-id="' . $mycat['id'] . '"><i class="fa fa-pencil icon-link orange" data-toggle="tooltip" title="Modifica"></i></a>';
/* L. Saggin End of modification */
b. manage_categories.php about line 373
<!-- L. Saggin Modification -->
<h4 class="modal-title" id="myModalLabel">Modifica Categoria</h4>
<!-- L. Saggin End Modification -->
This way, however I cannot provide an English language fully supported anymore. Better: if one translates these two lines then (s)he has to choose which language should be fully supported.
I know, I'm finicky
3. This is more a problem for me, but can be general for all those who requires a full implementation of the Name of the customers.
In fact the ticket form reports the field "Name" and the customer must indicate his/her Name. That is correct.
However my experience is that persons use *JUST* their Name, not their surname+name!
We are a Interdepartmental University facility and our helpdesk is only for an internal users. So we need to identify *exactly* who is submitting ticket (the email cannot be always useful). In our case there is no problem of privacy: if someone wants to have his/her not working air conditioning system or his/her dropping taps fixed in his/her labs, then we must know who is who.
So at first I tried to translate $hesklang['name'] as "Cognome e Nome" (ie Surname & Name) and NOT "Name".
Unfortunately this variable is used also in other places where it must be exactly "Name" and NOT "Surname & Name".
So I decided to leave it as it was, and I added another variable, I called $hesklang['surname'] which I substituted in the file "index.php" of the root directory as reported below:
index.php line 318
/* L. Saggin Modification */
} ?> placeholder="<?php echo htmlspecialchars($hesklang['surname']); ?>"
/* L. Saggin End of Modification*/
This way when one submits a ticket, then at least (s)he sees inside the box whose label (fieldname) is "Name" that (s)he has to fill in with *both* Name and Surname.
Thanks for the attention.
Topoldo/Leopoldo