How can I change the default width?

[sc123]

Script URL:
Version of script:0.94.1
Hosting company:
URL of phpinfo.php:
URL of session_test.php:
What terms did you try when SEARCHING for a solution: change width

Write your message below:

I'd like to change the default width from what appears to be 750 to something less (I'll have to play with the number). I see where there is a table defined with a size of 750 in index.php but changing this doesn't affect the output. Since all of the page content seem to be within the same 750px box, I figured there may be one place I can change it that will affect all of the content, though I'm really just interested in changing what the customer sees.

Thanks for the great script!

[sc123]

I know the code I'm looking for isn't in hesk_style.css. I have also searched all of the files for "750" but changing those results to "650" has no effect on the table size seen by the user. I'd appreciate any advice!

[Klemen]

It's all in the code. The overall table is in the /inc/header.inc.php file (770 px), and the 750 px tables are basically in every file that prints out HTML code.

[sc123]

"/inc/header.inc.php file (770 px)" is all I needed to know! Thanks!

[DC]

Yup I just did some serious integration my self and found that not only must you watch for the 750px tables you must also look for some offending HR rules that are set as well that will blow your layout ...

My suggestion for future versions is to set only one master table and everthing in it to 100% what this does is then allows for a completely dynamic layout that can adjust and fit into any layout or template you use.

Thats what I ended up doing and it works great.
I also did a slew of mods to it as well one being that all the dates are presented to my self the admin and my clients as a MYSQL based date format so I realy dislike that and have reformated it so it outputs as 12/08/07 2:45 AM. I couldnt find a way to do this in the admin so a created my own mod to do it this only efects the output you see it has nothing to do with whats stored in the db .. so no wory causing probs there.

Overall the scripts rocks Im just one to take it to the next lev
I noted that it creates seperate tables for each custom field that caused the added fields to not realy line up perfectly with the existing fields so the added ones stuck out, not sure if any one noticed this or not but I did and just had to fix it that is a tad tricky becouse we want to just create the table data and rows not a compleately new table that does not line up.

I will post a screan shot of the tight integration when i feel its complete
I also eliminated the need for the heder footer txt files i would rather jst edit the header footer php files directly instead ... this also will prevent having to head tags becouse if you include full head data the script is allready including its own html head so you can wind up with 2, not what we want. so these are a few mods I made to the script i thoght i would share on the forum ...

[Klemen]

Yeah, we talked via e-mail about all this, didn't we?

Just one thing isn't celar,

I noted that it creates seperate tables for each custom field that caused the added fields to not realy line up perfectly with the existing fields so the added ones stuck out,

It doesn't create a new table for each custom field, if you look at the original code:

Code: Select all

    echo '<table border="0">';

    foreach ($hesk_settings['custom_fields'] as $k=>$v) {
        if ($v['use']) {
            if ($v['req']) {$v['req']='<font class="important">*</font>';}
            else {$v['req']='';}
            $k_value = stripslashes(hesk_input($_SESSION["c_$k"]));
            echo <<<EOC
    <tr>
    <td align="right" width="150">$v[name]: $v[req]</td>
    <td align="left" width="600"><input type="text" name="$k" size="40" maxlength="$v[maxlen]" value="$k_value"></td>
    </tr>

EOC;
        }
    }

    echo '</table> <hr>';

They are all in one table. Or was it something else you meant?

[DC]

Ah I see I have been challenged by Klem himself

Yes we did touch on this in an email allong with the width problem that I felt should not be set throghout in the next ver I do know how your loop works ...

Ok I guess I did not explain what I meant correctly, and I do not wnat to confusse our users, what I meant is that the whole form is made up of seperate tables and then when we add a custom field it builds another seperate table, in doing this none of our fields can lineup perfectly, so when we add our new custom field it now does not linup with our other tables.

I have an example below showing this, but to better explain it lets start with our raw table data and then adjust our width this way you can see just how out of alignment it can get. I have turned borders on to expose our tables. You will see that each set of fields is in its own table that is nested in our master table with each seperated by hr rules.

http://clickcraft.net/junk/phpjunk_table.gif

In my mod I am having our loop build rows onto our nested table this preserves the alignment we do have becouse its now all part of the one nested table. while this is not a big deal its just somthing that bothered the heck out of me. Others may not have noticed or mind but I do so I just had to mod the way it works and thoght I would share what I found with the other users ...

here is the mod version Note it now all lines up perfectly even when when
adding our other custom fields into the mix top or bot ...

http://clickcraft.net/junk/phpjunk_table_fix.gif

Now heres the completed mod tightly integrated into a site layout I did.
I Thought after all this might as well show you the finishd product, it turns your otherwise great script into a very slick highly integrated script that can with a little work become part of a site. I thoght this to be a great example of what can be done with it. I also feel maybe you should have a section that showcases slick mods that others have done to integrate the script into a site.

http://clickcraft.net/junk/phpjunk_table_mod.gif

DC

[Klemen]

Ah, I understand now what you mean. This however is not problem with the original version, because cell width is fixed and fields do align properly:
http://www.phpjunkyard.com/hesk/index.php?a=add

You could still use such setup in your case, just make widths %, like one cell 30% and the other 70%. The misaligned picture you attached is probably without any cell widths defined?

[DC]

Glad that explained it better.

Actually you would think that would work just fine and in some cases it does, but many times it does not work as one would expect depending on what we have in our cells this is also dif for some browsers if you look closely at the link you sent me to, yes it does line up better becouse you have it all set at 750 fixed but it is not perfect look again the other tables are out a few pixels. Hey im supper criticle what can I say Im just pointing it out ...

And the example used is your demo page raw no css, all I did for this test was changed the width ... and when we do so you see what happens the whole darn thing misaligns so really the only sure fire way is with the way I modified it to work becouse that way the alignment of one controls all but that said I know im spliting hairs here ...

I want to point out a mail problem few may know but I discovered a ways back. Did you know that the way you and many others send the mail will fail sending mail to AOL while this may seem trivial its important as there are a ton of AOL users that may just never get the mail the system sends.

Why? well the reason is quite simple but often overlooked, AOL is looking for the return path to be valid so to make this send to AOL users this mod is required or they may never get the mail from hesk.

Heres the solution ...
We add the following header to the section where our mail func is.
It can be added just under the Reply-To header ...

$headers.="Return-Path: $hesk_settings[webmaster_mail]\n";

This will return a valid email addy thus AOL will then deliver the mail.
So for anyone whos visitors complain they never get the maiil sent you can try this fix ...

DC

[Klemen]

I wasn't aware of the AOL return-path requirements, do you have any official reports/notifications about this? Didn't hear of any problems yet regarding sending to AOL, but thanks for letting me know, definitely something that is easy to add to the next release.

As for the table - sure, this should be fixed easily as well. I was hoping to completely redesign the Hesk interface in the future, something was posted here:
viewtopic.php?t=930

But I don't know if Kevin will be able to finish this and when

[DC]

Im not sure about official from AOL but I can tell you I have done tons of testing on the reason why my aol users were complaining about not getting the mail from my own mail based scripts becouse there does not seem to be great documentation on this that I found at the time and aol is kinda a secret company as you may know they make changes many times without you even knowing I think its all part of there spam detection sys ...

Any way what I found is that if theres no valid return path AOL will many times never deliver the mail so my rule of thumb has been to add the Return into all my email scripts with a valid Retun email and all is fine just a fine I found this works becouse in my tests if I add that line it will deliver the mail if i remove it it will not send the mail but at the same time the same test IT will deliver the mail without that line to other ISPs ...

So they are def checking that is valid. Just thoght i would share what i know as your script did not send mail to me in my own AOL test after adding that line now it sends mail to me and I have AOL as well so i can run these tests before I get complaints ...

Heres an interesting tidbit that talks about what im saying.
it also talks about a parameter you can add, but I found my trick works
In every test I tried ...

http://www.sitecrafting.com/blog/aol-denying-email/

Yes I saw the beta look before very cool ...

DC

[Klemen]

Thanks for letting me know, will make sure it's added to the next version!

If they are really enforcing this policy then I guess most scripts are having problems sending mail to AOL.

[DC]

Yesere most scripts I tested do have the problem, along with my own I have modified so that they work correctly you just must make sure that its valid the no-reply stuff will usually not work.

Thats why if you look at the line mod I provided it has the valid webmaster e as this will validate ...

DC